From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12824 invoked by alias); 23 Oct 2019 16:29:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12814 invoked by uid 89); 23 Oct 2019 16:29:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Oct 2019 16:29:47 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id DEC3120183; Wed, 23 Oct 2019 12:29:45 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 6C53E20183; Wed, 23 Oct 2019 12:29:44 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 48E9F2192E; Wed, 23 Oct 2019 12:29:44 -0400 (EDT) X-Gerrit-PatchSet: 3 Date: Wed, 23 Oct 2019 16:29:00 -0000 From: "Tom de Vries (Code Review)" To: gdb-patches@sourceware.org Cc: Luis Machado , Andrew Burgess Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v3] [gdb/symtab] Prefer var def over decl X-Gerrit-Change-Id: Id92326cb8ef9903b121ef9e320658eb565d0f5a9 X-Gerrit-Change-Number: 29 X-Gerrit-ChangeURL: X-Gerrit-Commit: cede0513116b126cb1ef7506cd1ff25eb86cf878 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 23 Oct 2019 12:29:44 -0400 Reply-To: tdevries@suse.de, andrew.burgess@embecosm.com, luis.machado@linaro.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191023162944.48E9F2192E@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00844.txt.bz2 Tom de Vries has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29 ...................................................................... Patch Set 3: (2 comments) Thanks for the comments, updated the patch set. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/2/gdb/block.c File gdb/block.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/2/gdb/block.c@737 PS2, Line 737: /* Return true if symbol A is a better match than symbol B for DOMAIN. */ > The comment is a bit misleading. […] Done https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/2/gdb/testsuite/gdb.dwarf2/varval.exp File gdb/testsuite/gdb.dwarf2/varval.exp: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/2/gdb/testsuite/gdb.dwarf2/varval.exp@209 PS2, Line 209: > Spurious new line? Done