From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93621 invoked by alias); 23 Oct 2019 14:31:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93565 invoked by uid 89); 23 Oct 2019 14:31:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=facts, HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Oct 2019 14:31:09 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 34783204A2; Wed, 23 Oct 2019 10:31:08 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 4BE0C20183; Wed, 23 Oct 2019 10:31:06 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 29E692192E; Wed, 23 Oct 2019 10:31:06 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Wed, 23 Oct 2019 14:31:00 -0000 From: "Tom Tromey (Code Review)" To: Tankut Baris Aktemur , gdb-patches@sourceware.org Cc: Andrew Burgess Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] gdb: recognize new DWARF attributes: defaulted, deleted, calling conv. X-Gerrit-Change-Id: I54192f363115b78ec7435a8563b73fcace420765 X-Gerrit-Change-Number: 135 X-Gerrit-ChangeURL: X-Gerrit-Commit: be2a724c69fd89d32b0829d500820f9c7f448c84 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 23 Oct 2019 10:31:06 -0400 Reply-To: tromey@sourceware.org, tankut.baris.aktemur@intel.com, andrew.burgess@embecosm.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191023143106.29E692192E@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00832.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/135 ...................................................................... Patch Set 1: (2 comments) Thank you for the patch. This looks essentially good to me. I had a couple of nits, related to structure packing and size. I assume this is used elsewhere in your series. Now that we're on gerrit and can't do cover letters, I think it would be helpful if supporting patches like this could mention facts like that... something for us all to consider as we write commit messages. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/135/1/gdb/gdbtypes.h File gdb/gdbtypes.h: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/135/1/gdb/gdbtypes.h@929 PS1, Line 929: unsigned int defaulted; Should this be a bit-field or a narrower integer type? I see `DW_DEFAULTED` only has 3 values at present. I guess we'd have to deal with the situation where the DWARF gives some random value here? Offhand I'm not sure whether space is a big consideration here or not, but my default with symbols and types is to assume that it is. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/135/1/gdb/gdbtypes.h@1101 PS1, Line 1101: unsigned calling_convention : 8; This might pack better up near the `is_dynamic` field.