From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7772 invoked by alias); 22 Oct 2019 16:47:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7701 invoked by uid 89); 22 Oct 2019 16:47:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1163 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Oct 2019 16:47:47 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id A10AB204A2; Tue, 22 Oct 2019 12:47:44 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 084F72018B; Tue, 22 Oct 2019 12:47:42 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id E5B342192E; Tue, 22 Oct 2019 12:47:41 -0400 (EDT) X-Gerrit-PatchSet: 6 Date: Tue, 22 Oct 2019 16:47:00 -0000 From: "Christian Biesinger (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Tom Tromey , Luis Machado , Sergio Durigan Junior Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v6] Use libxxhash for hashing, if present X-Gerrit-Change-Id: Icab218388b9f829522ed3977f04301ae6d4fc4ca X-Gerrit-Change-Number: 39 X-Gerrit-ChangeURL: X-Gerrit-Commit: ccb1ba62299edce72053dd567b9d384814e11885 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 22 Oct 2019 12:47:41 -0400 Reply-To: cbiesinger@google.com, tromey@sourceware.org, sergiodj@redhat.com, luis.machado@linaro.org, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191022164741.E5B342192E@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00799.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/39 ...................................................................... Patch Set 6: (1 comment) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/39/5/gdb/configure.ac File gdb/configure.ac: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/39/5/gdb/configure.ac@2224 PS5, Line 2224: AC_MSG_CHECKING([whether to use xxhash]) : AC_MSG_RESULT([$with_xxhash]) : : if test "x$with_xxhash" != "xno"; then : AC_LIB_HAVE_LINKFLAGS([xxhash], [], : [#include ], : [XXH32("foo", 3, 0); : ]) : if test "$HAVE_XXHASH" != yes; then : if test "$with_xxhash" = yes; then : AC_MSG_ERROR([xxhash is missing or unusable]) : fi : fi : fi > I think the `auto` case here should not error if the library is missing. […] It doesn't error for auto (due to the with_xxhash=yes check), but it does show auto as the result which is not ideal. That's what I get for copying the babeltrace code :-) Now fixed, will show: checking for libxxhash... no checking whether to use xxhash... no