[review v6] Use libxxhash for hashing, if present

Christian Biesinger (Code Review)
2019-10-22T16:47:49Z

Christian Biesinger has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/39
......................................................................

Patch Set 6:

(1 comment)

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/39/5/gdb/configure.ac
File gdb/configure.ac:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/39/5/gdb/configure.ac@2224
PS5, Line 2224: AC_MSG_CHECKING([whether to use xxhash])
: AC_MSG_RESULT([$with_xxhash])
:
: if test "x$with_xxhash" != "xno"; then
: AC_LIB_HAVE_LINKFLAGS([xxhash], [],
: [#include <xxhash.h>],
: [XXH32("foo", 3, 0);
: ])
: if test "$HAVE_XXHASH" != yes; then
: if test "$with_xxhash" = yes; then
: AC_MSG_ERROR([xxhash is missing or unusable])
: fi
: fi
: fi
> I think the `auto` case here should not error if the library is missing. […]
It doesn't error for auto (due to the with_xxhash=yes check), but it does show auto as the result which is not ideal. That's what I get for copying the babeltrace code :-)

Now fixed, will show:
checking for libxxhash... no
checking whether to use xxhash... no