From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88447 invoked by alias); 22 Oct 2019 16:27:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88433 invoked by uid 89); 22 Oct 2019 16:27:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Oct 2019 16:27:43 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 7663720172; Tue, 22 Oct 2019 12:27:42 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 64CC320176; Tue, 22 Oct 2019 12:27:40 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id C3FA42192E; Tue, 22 Oct 2019 12:27:38 -0400 (EDT) X-Gerrit-PatchSet: 2 Date: Tue, 22 Oct 2019 16:27:00 -0000 From: "Simon Marchi (Code Review)" To: Tankut Baris Aktemur , gdb-patches@sourceware.org Cc: Tom de Vries , Luis Machado Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] infcall: move assertions in 'call_function_by_hand_dummy' to an earli... X-Gerrit-Change-Id: I411ac083ac6a9ee6eb93c4b82393a81a4fc927be X-Gerrit-Change-Number: 139 X-Gerrit-ChangeURL: X-Gerrit-Commit: 93b31c66931ce0ef800ed7ad8ce5faaa3c2eae04 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 22 Oct 2019 12:27:38 -0400 Reply-To: simon.marchi@polymtl.ca, tankut.baris.aktemur@intel.com, tdevries@suse.de, luis.machado@linaro.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191022162738.C3FA42192E@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00797.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/139 ...................................................................... Patch Set 2: Code-Review+2 Thanks, LGTM too. I've seen that you are already in the process of getting write access, this is ok to push once you have it.