Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Christian Biesinger (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>,	gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@sourceware.org>,
	Simon Marchi <simon.marchi@polymtl.ca>
Subject: [review v5] Store the mangled name as a string_view
Date: Tue, 22 Oct 2019 16:17:00 -0000	[thread overview]
Message-ID: <20191022161729.91C4C2192E@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571050562000.I24711ae2bcaa9e79ca89a6f8fda385d400419175@gnutoolchain-gerrit.osci.io>

Christian Biesinger has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37
......................................................................


Patch Set 5:

(1 comment)

Thanks for the reviews! Will push once I update the rest of this patch series per your comments.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37/5/gdb/symtab.c 
File gdb/symtab.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37/5/gdb/symtab.c@903 
PS5, Line 903: 	  new (*slot) demangled_name_entry
> FWIW I don't think there's a deep reason these objects have to […]
OK, I'll keep that in mind.




  parent reply	other threads:[~2019-10-22 16:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <gerrit.1571050562000.I24711ae2bcaa9e79ca89a6f8fda385d400419175@gnutoolchain-gerrit.osci.io>
2019-10-16 13:08 ` [review] " Christian Biesinger (Code Review)
2019-10-21 20:15 ` [review v3] " Christian Biesinger (Code Review)
2019-10-21 22:39 ` Simon Marchi (Code Review)
2019-10-21 23:13 ` [review v5] " Christian Biesinger (Code Review)
2019-10-21 23:13 ` Christian Biesinger (Code Review)
2019-10-22  4:15 ` Simon Marchi (Code Review)
2019-10-22 16:06 ` Tom Tromey (Code Review)
2019-10-22 16:17 ` Christian Biesinger (Code Review) [this message]
2019-10-22 16:47 ` [review v6] " Christian Biesinger (Code Review)
2019-10-22 17:55 ` [pushed] " Sourceware to Gerrit sync (Code Review)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191022161729.91C4C2192E@gnutoolchain-gerrit.osci.io \
    --to=gerrit@gnutoolchain-gerrit.osci.io \
    --cc=cbiesinger@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    --cc=tromey@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox