From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8746 invoked by alias); 22 Oct 2019 16:11:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8737 invoked by uid 89); 22 Oct 2019 16:11:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=yours, interest, HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Oct 2019 16:11:16 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 1497720172; Tue, 22 Oct 2019 12:11:14 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 2683D20176; Tue, 22 Oct 2019 12:11:14 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 11D7E2192E; Tue, 22 Oct 2019 12:11:14 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Tue, 22 Oct 2019 16:11:00 -0000 From: "Tom Tromey (Code Review)" To: Andrew Burgess , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] gdb/testsuite: Introduce compiler_supports_ctf_debug guard function X-Gerrit-Change-Id: I505c11169a9bc9871a31fc0c61e119f92f32cc63 X-Gerrit-Change-Number: 121 X-Gerrit-ChangeURL: X-Gerrit-Commit: bc9c27ec3445190919b27dc6dd9ab1197bd9921a In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 22 Oct 2019 12:11:13 -0400 Reply-To: tromey@sourceware.org, andrew.burgess@embecosm.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191022161114.11D7E2192E@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00795.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/121 ...................................................................... Patch Set 1: > > I tend to suspect this should wait for the other patch (mentioned below). > > What do you think? > > That's fine. I originally posted this to the m/l while back[1], I hadn't noticed that Nick had duplicated the work since then. My main interest is the other two patches in this series. > > [1] https://sourceware.org/ml/gdb-patches/2019-10/msg00220.html If yours came first, I'm ok if you want to get it in earlier so you can unblock your other patches. I do think it should use `unsupported` though. Thanks again for doing this.