From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>, gdb-patches@sourceware.org
Cc: Luis Machado <luis.machado@linaro.org>,
Sergio Durigan Junior <sergiodj@redhat.com>
Subject: [review v5] Use libxxhash for hashing, if present
Date: Tue, 22 Oct 2019 16:02:00 -0000 [thread overview]
Message-ID: <20191022160159.0F7A52192E@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571050562000.Icab218388b9f829522ed3977f04301ae6d4fc4ca@gnutoolchain-gerrit.osci.io>
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/39
......................................................................
Patch Set 5:
(1 comment)
Thank you. This looks good to me, though I had one suggestion
for the configure change.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/39/5/gdb/configure.ac
File gdb/configure.ac:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/39/5/gdb/configure.ac@2224
PS5, Line 2224: AC_MSG_CHECKING([whether to use xxhash])
: AC_MSG_RESULT([$with_xxhash])
:
: if test "x$with_xxhash" != "xno"; then
: AC_LIB_HAVE_LINKFLAGS([xxhash], [],
: [#include <xxhash.h>],
: [XXH32("foo", 3, 0);
: ])
: if test "$HAVE_XXHASH" != yes; then
: if test "$with_xxhash" = yes; then
: AC_MSG_ERROR([xxhash is missing or unusable])
: fi
: fi
: fi
I think the `auto` case here should not error if the library is missing.
Instead it should just switch to `no`. This also means that the
`AC_MSG_RESULT` should be moved lower.
next prev parent reply other threads:[~2019-10-22 16:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gerrit.1571050562000.Icab218388b9f829522ed3977f04301ae6d4fc4ca@gnutoolchain-gerrit.osci.io>
2019-10-15 23:25 ` [review] " Sergio Durigan Junior (Code Review)
2019-10-16 13:09 ` Christian Biesinger (Code Review)
2019-10-16 13:09 ` Christian Biesinger (Code Review)
2019-10-21 21:16 ` [review v3] " Luis Machado (Code Review)
2019-10-22 16:02 ` Tom Tromey (Code Review) [this message]
2019-10-22 16:47 ` [review v6] " Christian Biesinger (Code Review)
2019-10-22 17:08 ` Tom Tromey (Code Review)
2019-10-22 17:55 ` [pushed] " Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022160159.0F7A52192E@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@linaro.org \
--cc=sergiodj@redhat.com \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox