From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-159945-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 129301 invoked by alias); 22 Oct 2019 04:32:50 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 129292 invoked by uid 89); 22 Oct 2019 04:32:49 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-7.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit
X-HELO: mx1.osci.io
Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Oct 2019 04:32:48 +0000
Received: by mx1.osci.io (Postfix, from userid 994)	id 55C50204CA; Tue, 22 Oct 2019 00:32:47 -0400 (EDT)
Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239])	by mx1.osci.io (Postfix) with ESMTP id D51252018B;	Tue, 22 Oct 2019 00:32:45 -0400 (EDT)
Received: from localhost (localhost [127.0.0.1])	by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id C02D52192E;	Tue, 22 Oct 2019 00:32:45 -0400 (EDT)
X-Gerrit-PatchSet: 1
Date: Tue, 22 Oct 2019 04:32:00 -0000
From: "Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>,	gdb-patches@sourceware.org
Cc: Luis Machado <luis.machado@linaro.org>
Auto-Submitted: auto-generated
X-Gerrit-MessageType: comment
Subject: [review] Don't make an extra copy + allocation of the demangled name
X-Gerrit-Change-Id: Ie6ad50e1e1e73509f55d756f0a437897bb93e3b0
X-Gerrit-Change-Number: 132
X-Gerrit-ChangeURL: <https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132>
X-Gerrit-Commit: 8dec8d2449194e5cc3980a652b0bb43a6bd69e0d
In-Reply-To: <gerrit.1571352433000.Ie6ad50e1e1e73509f55d756f0a437897bb93e3b0@gnutoolchain-gerrit.osci.io>
References: <gerrit.1571352433000.Ie6ad50e1e1e73509f55d756f0a437897bb93e3b0@gnutoolchain-gerrit.osci.io>
X-Gerrit-Comment-Date: Tue, 22 Oct 2019 00:32:45 -0400
Reply-To: simon.marchi@polymtl.ca, luis.machado@linaro.org, cbiesinger@google.com, gdb-patches@sourceware.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/3.0.3
Content-Type: text/plain; charset=UTF-8
Message-Id: <20191022043245.C02D52192E@gnutoolchain-gerrit.osci.io>
X-SW-Source: 2019-10/txt/msg00777.txt.bz2

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132
......................................................................


Patch Set 1:

(1 comment)

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/1/gdb/symtab.c 
File gdb/symtab.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/1/gdb/symtab.c@718 
PS1, Line 718:   char* demangled;
Would it make sense to rebase that patch over your other series (especially https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37/5).  This field could become a gdb::unique_xmalloc_ptr.  Since you already call the destructor in the other patch, this will get cleaned up automatically.