[review v3] Store the mangled name as a string_view

Simon Marchi (Code Review)
2019-10-21T22:39:56Z

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37
......................................................................

Patch Set 3:

(1 comment)

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37/3/gdb/symtab.c
File gdb/symtab.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37/3/gdb/symtab.c@891
PS3, Line 891: + demangled_len + 1));
Pedantically, since demangled_name_entry is now a non-POD, we should run the constructor here and the destructor when we release them. Running the constructor here would not be too complicated, but running the destructor might be a bit more (and maybe it's not really necessary), I guess we'd need a "delete" function on the htab.