[review v5] Store the mangled name as a string_view

Tom Tromey (Code Review)
2019-10-22T16:06:58Z

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37
......................................................................

Patch Set 5:

(1 comment)

I had a comment on this one, but I agree with Simon that this is fine as-is.

Thanks for doing this.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37/5/gdb/symtab.c
File gdb/symtab.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37/5/gdb/symtab.c@903
PS5, Line 903: new (*slot) demangled_name_entry
FWIW I don't think there's a deep reason these objects have to
be stored on an obstack. We could just use plain new and make
`free_demangled_name_entry` a wrapper for `delete`. Or maybe
it's finally time to import some version of the gcc hash table.