From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-159942-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 85212 invoked by alias); 22 Oct 2019 04:15:51 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 85204 invoked by uid 89); 22 Oct 2019 04:15:51 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-7.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:338, HContent-Transfer-Encoding:8bit
X-HELO: mx1.osci.io
Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Oct 2019 04:15:50 +0000
Received: by mx1.osci.io (Postfix, from userid 994)	id D1D022022D; Tue, 22 Oct 2019 00:15:48 -0400 (EDT)
Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239])	by mx1.osci.io (Postfix) with ESMTP id 6DF8D2018B;	Tue, 22 Oct 2019 00:15:47 -0400 (EDT)
Received: from localhost (localhost [127.0.0.1])	by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 47BB62192E;	Tue, 22 Oct 2019 00:15:47 -0400 (EDT)
X-Gerrit-PatchSet: 5
Date: Tue, 22 Oct 2019 04:15:00 -0000
From: "Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>,	gdb-patches@sourceware.org
Auto-Submitted: auto-generated
X-Gerrit-MessageType: comment
Subject: [review v5] Store the mangled name as a string_view
X-Gerrit-Change-Id: I24711ae2bcaa9e79ca89a6f8fda385d400419175
X-Gerrit-Change-Number: 37
X-Gerrit-ChangeURL: <https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37>
X-Gerrit-Commit: 2c8260147f0115c20a625cb5d776403ac1cbca2f
In-Reply-To: <gerrit.1571050562000.I24711ae2bcaa9e79ca89a6f8fda385d400419175@gnutoolchain-gerrit.osci.io>
References: <gerrit.1571050562000.I24711ae2bcaa9e79ca89a6f8fda385d400419175@gnutoolchain-gerrit.osci.io>
X-Gerrit-Comment-Date: Tue, 22 Oct 2019 00:15:47 -0400
Reply-To: simon.marchi@polymtl.ca, cbiesinger@google.com, gdb-patches@sourceware.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/3.0.3
Content-Type: text/plain; charset=UTF-8
Message-Id: <20191022041547.47BB62192E@gnutoolchain-gerrit.osci.io>
X-SW-Source: 2019-10/txt/msg00774.txt.bz2

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37
......................................................................


Patch Set 5: Code-Review+2

Thanks, this LGTM.  Just make sure to update the ChangeLog entry.