From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56750 invoked by alias); 21 Oct 2019 23:19:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56742 invoked by uid 89); 21 Oct 2019 23:19:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Oct 2019 23:19:10 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id E323720293; Mon, 21 Oct 2019 19:19:08 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 4F83820172; Mon, 21 Oct 2019 19:19:05 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 2FB2F21926; Mon, 21 Oct 2019 19:19:05 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Mon, 21 Oct 2019 23:19:00 -0000 From: "Luis Machado (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Don't make an extra copy + allocation of the demangled name X-Gerrit-Change-Id: Ie6ad50e1e1e73509f55d756f0a437897bb93e3b0 X-Gerrit-Change-Number: 132 X-Gerrit-ChangeURL: X-Gerrit-Commit: 8dec8d2449194e5cc3980a652b0bb43a6bd69e0d In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 21 Oct 2019 19:19:05 -0400 Reply-To: luis.machado@linaro.org, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191021231905.2FB2F21926@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00771.txt.bz2 Luis Machado has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132 ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Although the obstack manipulation bits are a bit odd with the offsets and potentially less than ideal documentation, this looks reasonable to me. Only a couple nits in formatting. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/1/gdb/symtab.c File gdb/symtab.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/1/gdb/symtab.c@718 PS1, Line 718: char* demangled; Usual style is "char *demangled;" i think. Although there is one offender in symtab.c already. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132/1/gdb/symtab.c@887 PS1, Line 887: Something odd here? Whitespace?