From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50684 invoked by alias); 21 Oct 2019 23:13:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50676 invoked by uid 89); 21 Oct 2019 23:13:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Oct 2019 23:13:53 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 0032420483; Mon, 21 Oct 2019 19:13:51 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 0660920172; Mon, 21 Oct 2019 19:13:50 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 0A3612192A; Mon, 21 Oct 2019 19:13:49 -0400 (EDT) X-Gerrit-PatchSet: 5 Date: Mon, 21 Oct 2019 23:13:00 -0000 From: "Christian Biesinger (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v5] Store the mangled name as a string_view X-Gerrit-Change-Id: I24711ae2bcaa9e79ca89a6f8fda385d400419175 X-Gerrit-Change-Number: 37 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2c8260147f0115c20a625cb5d776403ac1cbca2f In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 21 Oct 2019 19:13:48 -0400 Reply-To: cbiesinger@google.com, simon.marchi@polymtl.ca, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191021231349.0A3612192A@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00769.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37 ...................................................................... Patch Set 5: (1 comment) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37/3/gdb/symtab.c File gdb/symtab.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/37/3/gdb/symtab.c@891 PS3, Line 891: + demangled_len + 1)); > Pedantically, since demangled_name_entry is now a non-POD, we should run the constructor here and th […] Sure, happy to add a delete function -- I have another pending patch that also needs one (https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/132). Done.