From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31098 invoked by alias); 21 Oct 2019 20:52:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31085 invoked by uid 89); 21 Oct 2019 20:52:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1999 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Oct 2019 20:52:32 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 614262018B; Mon, 21 Oct 2019 16:52:31 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 15B522018E; Mon, 21 Oct 2019 16:52:29 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id E63AD21926; Mon, 21 Oct 2019 16:52:28 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Mon, 21 Oct 2019 20:52:00 -0000 From: "Luis Machado (Code Review)" To: Tom de Vries , gdb-patches@sourceware.org Cc: Joel Brobecker , Tom Tromey , Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] [gdb/testsuite] Compile ada with -lgnarl_pic and -lgnat_pic if required X-Gerrit-Change-Id: I3e1e40bd46236b45e2d7808c1cd744a075d4a148 X-Gerrit-Change-Number: 32 X-Gerrit-ChangeURL: X-Gerrit-Commit: 7bcc5dcb2d898f8a727a668c8e73a13bf42c22b7 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 21 Oct 2019 16:52:28 -0400 Reply-To: luis.machado@linaro.org, simon.marchi@polymtl.ca, tdevries@suse.de, tromey@sourceware.org, brobecker@adacore.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191021205228.E63AD21926@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00752.txt.bz2 Luis Machado has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/32 ...................................................................... Patch Set 1: (4 comments) At first the change looked a bit too complicated for what it does. But i realized that, if we don't want to keep compiling things incorrectly over and over again, caching the setting is the only way to do it. And that makes the code a bit larger. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/32/1/gdb/testsuite/lib/ada.exp File gdb/testsuite/lib/ada.exp: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/32/1/gdb/testsuite/lib/ada.exp@16 PS1, Line 16: # Call target_compile with SOURCE DEST TYPE and OPTIONS as argument, : # after having temporarily changed the current working directory to : # BUILDDIR. The location of this comment needs to be adjusted, since it is now out of place. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/32/1/gdb/testsuite/lib/ada.exp@20 PS1, Line 20: proc gdb_simple_compile_ada {name code {type object} {compile_flags {}} {object obj}} { Some documentation for this function would be nice. It seems to be a helper function that returns true/false for whether a compilation succeeded or not? https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/32/1/gdb/testsuite/lib/ada.exp@55 PS1, Line 55: gdb_caching_proc gdb_ada_needs_libs_pic_suffix { It would be nice to have some documentation here explaining that we're caching true/false for whether we need to use the special workaround compilation flags. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/32/1/gdb/testsuite/lib/ada.exp@131 PS1, Line 131: # Compile some Ada code. I think this is now a helper function? Should we adjust its documentation a bit? My understanding is that gdb_compile_ada_1 now only silently tests a compilation and doesn't actually gdb_compile_test it?