[review] infcall: move assertions in 'call_function_by_hand_dummy' to an earli...

Simon Marchi (Code Review)
2019-10-21T19:00:39Z

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/139
......................................................................

Patch Set 1:

> Patch Set 1: Code-Review+1
>
> I'd make it clear, in the cover letter/commit message, the reason for refactoring. As for the explanation, it sounds good to me.
>
> I agree we should check all the easy things before doing any further processing towards a function call. This looks like a small optimization of sorts.

Agreed, please put this in the commit message.