From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118231 invoked by alias); 21 Oct 2019 18:55:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 117989 invoked by uid 89); 21 Oct 2019 18:55:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:586, letter, HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Oct 2019 18:55:19 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id DCABC204C5; Mon, 21 Oct 2019 14:55:17 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 6BB2E2022D; Mon, 21 Oct 2019 14:55:16 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 4AEC121926; Mon, 21 Oct 2019 14:55:16 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Mon, 21 Oct 2019 18:55:00 -0000 From: "Luis Machado (Code Review)" To: Tankut Baris Aktemur , gdb-patches@sourceware.org Cc: Tom de Vries Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] infcall: move assertions in 'call_function_by_hand_dummy' to an earli... X-Gerrit-Change-Id: I411ac083ac6a9ee6eb93c4b82393a81a4fc927be X-Gerrit-Change-Number: 139 X-Gerrit-ChangeURL: X-Gerrit-Commit: 36ec4e04bb56dca32d147449d58428143836ddc6 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 21 Oct 2019 14:55:16 -0400 Reply-To: luis.machado@linaro.org, tankut.baris.aktemur@intel.com, tdevries@suse.de, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191021185516.4AEC121926@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00740.txt.bz2 Luis Machado has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/139 ...................................................................... Patch Set 1: Code-Review+1 I'd make it clear, in the cover letter/commit message, the reason for refactoring. As for the explanation, it sounds good to me. I agree we should check all the easy things before doing any further processing towards a function call. This looks like a small optimization of sorts.