From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81214 invoked by alias); 19 Oct 2019 20:43:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81204 invoked by uid 89); 19 Oct 2019 20:43:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 19 Oct 2019 20:43:05 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 55E6D201A1; Sat, 19 Oct 2019 16:43:02 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 27D8A20183; Sat, 19 Oct 2019 16:43:00 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id E34C320AF6; Sat, 19 Oct 2019 16:42:59 -0400 (EDT) X-Gerrit-PatchSet: 2 Date: Sat, 19 Oct 2019 20:43:00 -0000 From: "Tom Tromey (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review v2] Replace some more qsort calls with std::sort X-Gerrit-Change-Id: Ibcddce12a3d07448701e731b7150fa23611d86de X-Gerrit-Change-Number: 131 X-Gerrit-ChangeURL: X-Gerrit-Commit: 349f7f4d7fb446acf95d025f588a37c9cf96dcbd In-Reply-To: References: X-Gerrit-Comment-Date: Sat, 19 Oct 2019 16:42:59 -0400 Reply-To: tromey@sourceware.org, simon.marchi@polymtl.ca, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191019204259.E34C320AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00660.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131 ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Thank you. I think this is ok now. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/breakpoint.c File gdb/breakpoint.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/breakpoint.c@522 PS1, Line 522: /* Array is sorted by bp_location_is_less_than - primarily by the ADDRESS. */ > Tom, I have made a change that should make the line length 80 columns for all users that haven't set […] Thanks to both of you. Simon, I had already modified my settings, just FYI. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/breakpoint.c@11462 PS1, Line 11462: return (a > b) < (a < b); > Done. > > I wonder why this code wasn't just subtracting one variable from the other in all these cases. Probably due to fear of underflow.