From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12702 invoked by alias); 18 Oct 2019 21:41:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12684 invoked by uid 89); 18 Oct 2019 21:41:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=gear, HX-Languages-Length:2825 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Oct 2019 21:41:12 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 7AD532095D; Fri, 18 Oct 2019 17:41:10 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 201E020674; Fri, 18 Oct 2019 17:41:09 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id F0E9020AF6; Fri, 18 Oct 2019 17:41:08 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Fri, 18 Oct 2019 21:41:00 -0000 From: "Christian Biesinger (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Replace some more qsort calls with std::sort X-Gerrit-Change-Id: Ibcddce12a3d07448701e731b7150fa23611d86de X-Gerrit-Change-Number: 131 X-Gerrit-ChangeURL: X-Gerrit-Commit: 3c939b2a7dd96566c8189bb17c63a1f25bd01ef2 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 18 Oct 2019 17:41:08 -0400 Reply-To: cbiesinger@google.com, tromey@sourceware.org, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191018214108.F0E9020AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00648.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131 ...................................................................... Patch Set 1: (9 comments) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/breakpoint.c File gdb/breakpoint.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/breakpoint.c@522 PS1, Line 522: /* Array is sorted by bp_location_is_less_than - primarily by the ADDRESS. */ > In gerrit I can't tell if this line is overlong. […] When you're logged in, you can set diff preferences using the "gear" icon on the right, where you can set the diff width to 80. That lets you see if a line is too long. (this line is 78 characters long) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/breakpoint.c@11440 PS1, Line 11440: return (a->address > b->address) < (a->address < b->address); > I think this can just be a->address < b->address ? Yeah, I think you're right. Done. I was confused by this code. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/breakpoint.c@11448 PS1, Line 11448: < (a->pspace->num < b->pspace->num)); > Likewise this can be simplified. […] Done https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/breakpoint.c@11450 PS1, Line 11450: /* Sort permanent breakpoints first. */ : if (a->permanent != b->permanent) Test of a multiline comment (I think you have to highlight in the code, then press c, instead of directly selectng multiple lines) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/breakpoint.c@11452 PS1, Line 11452: return (a->permanent < b->permanent) < (a->permanent > b->permanent); > Ditto. Done https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/breakpoint.c@11460 PS1, Line 11460: < (a->owner->number < b->owner->number)); > Ditto. Done https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/breakpoint.c@11462 PS1, Line 11462: return (a > b) < (a < b); > Even here. Done. I wonder why this code wasn't just subtracting one variable from the other in all these cases. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/disasm.c File gdb/disasm.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/disasm.c@184 PS1, Line 184: val = mle1.start_pc - mle2.start_pc; > This code is a bit weird. It only works because "val" has signed type, […] Done https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/mdebugread.c File gdb/mdebugread.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/131/1/gdb/mdebugread.c@4570 PS1, Line 4570: addr_diff = (BLOCK_START (b1)) - (BLOCK_START (b2)); > This has the same oddity involving signs. I think just using the […] Done