From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100651 invoked by alias); 18 Oct 2019 16:44:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100639 invoked by uid 89); 18 Oct 2019 16:44:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Oct 2019 16:44:55 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 186F52096E; Fri, 18 Oct 2019 12:44:52 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 208A020905; Fri, 18 Oct 2019 12:44:52 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id E761220AF6; Fri, 18 Oct 2019 12:44:51 -0400 (EDT) X-Gerrit-PatchSet: 2 Date: Fri, 18 Oct 2019 16:44:00 -0000 From: "Tom de Vries (Code Review)" To: gdb-patches@sourceware.org Cc: Luis Machado , Andrew Burgess Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] [gdb/symtab] Prefer var def over decl X-Gerrit-Change-Id: Id92326cb8ef9903b121ef9e320658eb565d0f5a9 X-Gerrit-Change-Number: 29 X-Gerrit-ChangeURL: X-Gerrit-Commit: f885ed071fe8d3124112e010fc0446374eb5aaf1 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 18 Oct 2019 12:44:51 -0400 Reply-To: tdevries@suse.de, andrew.burgess@embecosm.com, luis.machado@linaro.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191018164451.E761220AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00639.txt.bz2 Tom de Vries has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29 ...................................................................... Patch Set 2: > Patch Set 2: Code-Review+1 > > (2 comments) > > I've noticed a couple nits. > > If PR91507 is fixed, do we need to patch GDB up? Yes. We need both the fix of PR91507 and this GDB patch to fix the test-case. > Or do we want to adapt GDB to the broken output from older GCC as well? As mentioned in the rationale, that is possible by getting the size from minimal symbol info, but I consider that a workaround rather than a fix. I've filed that as a separate PR: https://sourceware.org/bugzilla/show_bug.cgi?id=24989 . > I'm inclined to at least add some comment to the code stating GCC's broken behavior and why we're fixing it in this particular way. > Ack, will add. > Otherwise this looks good to me.