From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62610 invoked by alias); 18 Oct 2019 13:31:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62597 invoked by uid 89); 18 Oct 2019 13:31:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=ps2, PS2, HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Oct 2019 13:31:23 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 2393620674; Fri, 18 Oct 2019 09:31:21 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 2B1AD206FC; Fri, 18 Oct 2019 09:31:20 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id D504720AF6; Fri, 18 Oct 2019 09:31:16 -0400 (EDT) X-Gerrit-PatchSet: 2 Date: Fri, 18 Oct 2019 13:31:00 -0000 From: "Luis Machado (Code Review)" To: Tom de Vries , gdb-patches@sourceware.org Cc: Andrew Burgess Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] [gdb/symtab] Prefer var def over decl X-Gerrit-Change-Id: Id92326cb8ef9903b121ef9e320658eb565d0f5a9 X-Gerrit-Change-Number: 29 X-Gerrit-ChangeURL: X-Gerrit-Commit: f885ed071fe8d3124112e010fc0446374eb5aaf1 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 18 Oct 2019 09:31:16 -0400 Reply-To: luis.machado@linaro.org, tdevries@suse.de, andrew.burgess@embecosm.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191018133116.D504720AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00623.txt.bz2 Luis Machado has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29 ...................................................................... Patch Set 2: Code-Review+1 (2 comments) I've noticed a couple nits. If PR91507 is fixed, do we need to patch GDB up? Or do we want to adapt GDB to the broken output from older GCC as well? I'm inclined to at least add some comment to the code stating GCC's broken behavior and why we're fixing it in this particular way. Otherwise this looks good to me. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/2/gdb/block.c File gdb/block.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/2/gdb/block.c@737 PS2, Line 737: /* Return true if symbol A is a better match than symbol B for DOMAIN. */ The comment is a bit misleading. Maybe "Return symbol A if it is a better match than symbol B for DOMAIN. Otherwise return B." It seems the default, if everything fails, is to return A? Maybe add that to the comment as well. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/2/gdb/testsuite/gdb.dwarf2/varval.exp File gdb/testsuite/gdb.dwarf2/varval.exp: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/29/2/gdb/testsuite/gdb.dwarf2/varval.exp@209 PS2, Line 209: Spurious new line?