From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8512 invoked by alias); 16 Oct 2019 22:19:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8504 invoked by uid 89); 16 Oct 2019 22:19:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=check_gnu_style.sh, sk:check_G, sk:0001Lo, check_gnu_stylesh X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Oct 2019 22:19:33 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 189A2208EF; Wed, 16 Oct 2019 18:19:32 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 2C3B520564; Wed, 16 Oct 2019 18:19:31 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 218DF20AF6; Wed, 16 Oct 2019 18:19:31 -0400 (EDT) X-Gerrit-PatchSet: 2 Date: Wed, 16 Oct 2019 22:19:00 -0000 From: "Christian Biesinger (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Simon Marchi , Tom de Vries Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Load system gdbinit files from a directory X-Gerrit-Change-Id: If233859ecc21bc6421d589b37cd658a3c7d030f2 X-Gerrit-Change-Number: 26 X-Gerrit-ChangeURL: X-Gerrit-Commit: f2e9c5adaa84b4807ff54f064f5701691bc4a38f In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 16 Oct 2019 18:19:30 -0400 Reply-To: cbiesinger@google.com, simon.marchi@polymtl.ca, tdevries@suse.de, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191016221931.218DF20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00522.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26 ...................................................................... Patch Set 2: (1 comment) > Patch Set 1: > > $ ../check_GNU_style.sh 0001-Load-system-gdbinit-files-from-a-directory.patch > I fixed those, except for the ones in the generated files. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/1/gdb/main.c File gdb/main.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26/1/gdb/main.c@287 PS1, Line 287: /* We effectively don't support "set script-extension off/soft", > So we should document that exception here ( https://sourceware. […] Done