From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65987 invoked by alias); 16 Oct 2019 18:02:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65979 invoked by uid 89); 16 Oct 2019 18:02:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:867, tend, HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Oct 2019 18:02:25 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 4B41720905; Wed, 16 Oct 2019 14:02:23 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id E75DB20623; Wed, 16 Oct 2019 14:02:21 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id C50BB20AF6; Wed, 16 Oct 2019 14:02:21 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Wed, 16 Oct 2019 18:02:00 -0000 From: "Tom Tromey (Code Review)" To: Andrew Burgess , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] gdb/testsuite: Introduce compiler_supports_ctf_debug guard function X-Gerrit-Change-Id: I505c11169a9bc9871a31fc0c61e119f92f32cc63 X-Gerrit-Change-Number: 121 X-Gerrit-ChangeURL: X-Gerrit-Commit: bc9c27ec3445190919b27dc6dd9ab1197bd9921a In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 16 Oct 2019 14:02:21 -0400 Reply-To: tromey@sourceware.org, andrew.burgess@embecosm.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191016180221.C50BB20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00508.txt.bz2 Tom Tromey has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/121 ...................................................................... Patch Set 1: (1 comment) Thanks for the patch. I tend to suspect this should wait for the other patch (mentioned below). What do you think? https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/121/1/gdb/testsuite/gdb.base/ctf-whatis.exp File gdb/testsuite/gdb.base/ctf-whatis.exp: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/121/1/gdb/testsuite/gdb.base/ctf-whatis.exp@19 PS1, Line 19: return 0 https://sourceware.org/ml/gdb-patches/2019-10/msg00450.html reviews a very similar patch. There I suggested using "unsupported" in these cases, since I think this is the current style.