From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68074 invoked by alias); 16 Oct 2019 16:53:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68058 invoked by uid 89); 16 Oct 2019 16:53:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:670, HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Oct 2019 16:53:38 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 6269720905; Wed, 16 Oct 2019 12:53:37 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 957A12061D; Wed, 16 Oct 2019 12:53:36 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 8435820AF6; Wed, 16 Oct 2019 12:53:36 -0400 (EDT) X-Gerrit-PatchSet: 2 Date: Wed, 16 Oct 2019 16:53:00 -0000 From: "Keith Seitz (Code Review)" To: gdb-patches@sourceware.org Cc: Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] DWARF reader: Reject sections with invalid sizes X-Gerrit-Change-Id: I896ac3b4eb2207c54e8e05c16beab3051d9b4b2f X-Gerrit-Change-Number: 127 X-Gerrit-ChangeURL: X-Gerrit-Commit: af180f59f5fd06a844572bd0cb23e7cb15b41381 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 16 Oct 2019 12:53:36 -0400 Reply-To: keiths@redhat.com, tromey@sourceware.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191016165336.8435820AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00501.txt.bz2 Keith Seitz has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/127 ...................................................................... Patch Set 2: (1 comment) Switched to phex_nz. Thanks for the review. https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/127/1/gdb/dwarf2read.c File gdb/dwarf2read.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/127/1/gdb/dwarf2read.c@2345 PS1, Line 2345: BFD_VMA_FMT "x) larger than the file size [in module %s]"), > BFD can set this to "I64", which isn't supported by gdbsupport/format.c. […] Done