From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-159664-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 38845 invoked by alias); 16 Oct 2019 16:02:19 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 38375 invoked by uid 89); 16 Oct 2019 16:02:19 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit
X-HELO: mx1.osci.io
Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Oct 2019 16:02:14 +0000
Received: by mx1.osci.io (Postfix, from userid 994)	id 06B8F206FC; Wed, 16 Oct 2019 12:02:12 -0400 (EDT)
Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239])	by mx1.osci.io (Postfix) with ESMTP id 26F6120564;	Wed, 16 Oct 2019 12:02:12 -0400 (EDT)
Received: from localhost (localhost [127.0.0.1])	by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 0B52D20AF6;	Wed, 16 Oct 2019 12:02:12 -0400 (EDT)
X-Gerrit-PatchSet: 1
Date: Wed, 16 Oct 2019 16:02:00 -0000
From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Keith Seitz <keiths@redhat.com>, gdb-patches@sourceware.org
Auto-Submitted: auto-generated
X-Gerrit-MessageType: comment
Subject: [review] DWARF reader: Reject sections with invalid sizes
X-Gerrit-Change-Id: I896ac3b4eb2207c54e8e05c16beab3051d9b4b2f
X-Gerrit-Change-Number: 127
X-Gerrit-ChangeURL: <https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/127>
X-Gerrit-Commit: b090e7117fd1585593fd363c452822d30a431f10
In-Reply-To: <gerrit.1571240333000.I896ac3b4eb2207c54e8e05c16beab3051d9b4b2f@gnutoolchain-gerrit.osci.io>
References: <gerrit.1571240333000.I896ac3b4eb2207c54e8e05c16beab3051d9b4b2f@gnutoolchain-gerrit.osci.io>
X-Gerrit-Comment-Date: Wed, 16 Oct 2019 12:02:11 -0400
Reply-To: tromey@sourceware.org, keiths@redhat.com, gdb-patches@sourceware.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/3.0.3
Content-Type: text/plain; charset=UTF-8
Message-Id: <20191016160212.0B52D20AF6@gnutoolchain-gerrit.osci.io>
X-SW-Source: 2019-10/txt/msg00496.txt.bz2

Tom Tromey has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/127
......................................................................


Patch Set 1:

(1 comment)

Looks good but see the note.  Thanks for doing this.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/127/1/gdb/dwarf2read.c 
File gdb/dwarf2read.c:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/127/1/gdb/dwarf2read.c@2345 
PS1, Line 2345: 	       BFD_VMA_FMT "x) larger than the file size [in module %s]"),
BFD can set this to "I64", which isn't supported by gdbsupport/format.c.  Maybe that should be fixed, but just using one of the gdb helpers like phex or whatever seems simpler... I don't see other uses of BFD_VMA_FMT in gdb.