From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11470 invoked by alias); 16 Oct 2019 15:54:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11455 invoked by uid 89); 16 Oct 2019 15:54:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Oct 2019 15:54:24 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 9815120674; Wed, 16 Oct 2019 11:54:22 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 4313720674; Wed, 16 Oct 2019 11:54:21 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 2346E20AF6; Wed, 16 Oct 2019 11:54:21 -0400 (EDT) X-Gerrit-PatchSet: 2 Date: Wed, 16 Oct 2019 15:54:00 -0000 From: "Christian Biesinger (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Allow not saving the signal state in SIGSETJMP X-Gerrit-Change-Id: Ib3010966050c64b4cc8b47d8cb45871652b0b3ea X-Gerrit-Change-Number: 124 X-Gerrit-ChangeURL: X-Gerrit-Commit: 0c336df9fa8d7e94e9b44c3527efc399031b68a3 In-Reply-To: References: X-Gerrit-Comment-Date: Wed, 16 Oct 2019 11:54:21 -0400 Reply-To: cbiesinger@google.com, tromey@sourceware.org, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191016155421.2346E20AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00495.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/124 ...................................................................... Patch Set 2: > Patch Set 2: > > Thank you for doing this. > > It seems reasonable to me. My only question is: how do we know it works? > > I guess one way would be to find a mangled string that causes a crash > (there may be some in bugzilla), then demangle it twice (using "demangle" > should be enough) -- the second time should still report the error. I went the easy way: +    *(int*)0=0; And got this output: ../../gdb/cp-support.c:1589: demangler-warning: unable to demangle '__progname' (demangler failed with signal 11) Unable to dump core, use `ulimit -c unlimited' before executing GDB next time. ../../gdb/cp-support.c:1603: demangler-warning: unable to demangle '__progname' (demangler failed with signal 11) A problem internal to GDB has been detected, further debugging may prove unreliable. Quit this debugging session? (y or n) n then: (gdb) demangle __progname Can't demangle "__progname" The same as without this patch applied. Although I am confused because I don't see where error_reported gets reset.