From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84754 invoked by alias); 15 Oct 2019 23:25:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84576 invoked by uid 89); 15 Oct 2019 23:25:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Oct 2019 23:25:41 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 1C7A9205E7; Tue, 15 Oct 2019 19:25:40 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id C2EC920674; Tue, 15 Oct 2019 19:25:38 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id A53E326976; Tue, 15 Oct 2019 19:25:38 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Tue, 15 Oct 2019 23:25:00 -0000 From: "Sergio Durigan Junior (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Sergio Durigan Junior Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Use libxxhash for hashing, if present X-Gerrit-Change-Id: Icab218388b9f829522ed3977f04301ae6d4fc4ca X-Gerrit-Change-Number: 39 X-Gerrit-ChangeURL: X-Gerrit-Commit: 5f48c5b5045159a87637b87f1ac0b8686a565fcb In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 15 Oct 2019 19:25:38 -0400 Reply-To: sergiodj@redhat.com, sergiodj@redhat.com, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191015232538.A53E326976@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00465.txt.bz2 Sergio Durigan Junior has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/39 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Aside from the minor nit of missing whitespace, this LGTM. Thanks! https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/39/1/gdb/utils.c File gdb/utils.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/39/1/gdb/utils.c@3447 PS1, Line 3447: return XXH64(str, len, 0); Missing whitespace between function name and open parenthesis.