From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77104 invoked by alias); 15 Oct 2019 08:43:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77033 invoked by uid 89); 15 Oct 2019 08:43:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=uploaded, visit, HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Oct 2019 08:42:59 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 4F089204BD; Tue, 15 Oct 2019 04:42:58 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id D3A3320956; Tue, 15 Oct 2019 04:42:50 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 8FAF529ED0; Tue, 15 Oct 2019 04:42:50 -0400 (EDT) X-Gerrit-PatchSet: 3 Date: Tue, 15 Oct 2019 08:43:00 -0000 From: "Christian Biesinger (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: Change in binutils-gdb[master]: Make tui-winsource not use breakpoint_chain X-Gerrit-Change-Id: Ic259b2c3a4c1f5a47f34cfd7fccbdcf274417429 X-Gerrit-Change-Number: 22 X-Gerrit-ChangeURL: X-Gerrit-Commit: 866195d06e6376ec97d45508b9dd7442210d7f8c In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 15 Oct 2019 04:42:49 -0400 Reply-To: cbiesinger@google.com, simon.marchi@polymtl.ca, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191015084250.8FAF529ED0@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00403.txt.bz2 Christian Biesinger has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/22 ...................................................................... Uploaded patch set 3. (1 comment) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/22/2/gdb/tui/tui-winsource.c File gdb/tui/tui-winsource.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/22/2/gdb/tui/tui-winsource.c@447 PS2, Line 447: return false; > Did you really want to introduce this `return false`? Ah, no, that was a mistake. Fixed. -- To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/22 To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings