From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113565 invoked by alias); 15 Oct 2019 08:32:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113545 invoked by uid 89); 15 Oct 2019 08:32:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*RU:sk:host86-, HX-Spam-Relays-External:sk:host86-, H*r:sk:host86-, colour X-HELO: mail-wm1-f44.google.com Received: from mail-wm1-f44.google.com (HELO mail-wm1-f44.google.com) (209.85.128.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Oct 2019 08:32:38 +0000 Received: by mail-wm1-f44.google.com with SMTP id m18so19293029wmc.1 for ; Tue, 15 Oct 2019 01:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=E10Qyd9d825iHPTmP0qwQkijzcE8HJqEum5XrX0o+H8=; b=CPcaJNVfNT5vgeewscz3KNbtLsBiaL17SjL/3Mbb/bDMIs1rJlM7PHCPrWj/HVzOcZ oCZz8dgc1V0qMY0PX4ymVqMRkjZ1YOFzCPLV0x7Wj1XeY/UeOAjitxJVI8+kutPkWv8E KcN/QBEL7bb/EOmrS9UJNsurSS1WIoyYd+dDeOwfFIH8ee9M7TCO06UI4qeOXkGlg3KR bEeSiYQeJfBefOVJ5EmIROs7SMrqSgehuNVq7VJjfO7TummPAQ3JTogYPM/Rm21lbqdp jyvfV4UUTI6n1uFQYO+TVfwUlI4+4GtdQ5bQqnimho7k3SXTxJnats/0ce8Y6eziWsPh TUiQ== Return-Path: Received: from localhost (host86-128-12-122.range86-128.btcentralplus.com. [86.128.12.122]) by smtp.gmail.com with ESMTPSA id x5sm26986162wrt.75.2019.10.15.01.32.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 15 Oct 2019 01:32:35 -0700 (PDT) Date: Tue, 15 Oct 2019 08:32:00 -0000 From: Andrew Burgess To: Tom Tromey Cc: "Maciej W. Rozycki" , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [binutils-gdb] Style the gdb welcome message Message-ID: <20191015083234.GT4962@embecosm.com> References: <20181228210008.91892.qmail@sourceware.org> <875zkr9c9p.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <875zkr9c9p.fsf@tromey.com> X-Fortune: You worry too much about your job. Stop it. You are not paid enough to worry. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00400.txt.bz2 * Tom Tromey [2019-10-14 16:45:54 -0600]: > Maciej> I missed that in the various distractions that kept me from using an > Maciej> up-to-date version of GDB, but now that I came across it the hard way the > Maciej> bright pink version line hurts my eyes and disturbs me. Setting: > Maciej> set style enabled off > Maciej> in ~/.gdbinit does not make any change to it, so I find it a functional > Maciej> regression. I'm sure there were important reasons to make this change, > Maciej> but can we please get it under user control somehow? > > I added this to make it clear to users that gdb is style-enabled now. > I guess I don't care much about this particular instance though. Maybe > removing it is the answer. > > I'm curious to hear what others think. In the absence of comments I'll > remove it sometime before 9.1, I think. Or I'll approve a patch to > do so. FWIW I hadn't even noticed the use of colour there, so it certainly doesn't bother me. On my machine with both a light background and a dark background I don't see a bright pink, but a darker pink. I guess there's no simple way that we could postpone printing the welcome message until some later point, say, just before GDB tries to print anything else? What this might mean is that if ~/.gdbinit contains only (or starts with) commands that produce no output, for example 'set style enabled off' then these would be processed before GDB printed the welcome message. I've not looked at the code at all, so have no idea how hard this would be to actually do... Thanks, Andrew