From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19597 invoked by alias); 15 Oct 2019 08:04:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19585 invoked by uid 89); 15 Oct 2019 08:04:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=visit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Oct 2019 08:04:19 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 479982093E; Tue, 15 Oct 2019 04:04:18 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 611F620862; Tue, 15 Oct 2019 04:04:13 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 3189129ECF; Tue, 15 Oct 2019 04:04:13 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Tue, 15 Oct 2019 08:04:00 -0000 From: "Tom de Vries (Code Review)" To: gdb-patches@sourceware.org Cc: Andrew Burgess , Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: Change in binutils-gdb[master]: [gdb/tdep] Fix 'Unexpected register class' assert in amd64_push_argum... X-Gerrit-Change-Id: I8b66345bbf5c00209ca75b1209fd4d60b36e9ede X-Gerrit-Change-Number: 30 X-Gerrit-ChangeURL: X-Gerrit-Commit: ca83e461aeb8437d5e45c51852a3ef9389c99376 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 15 Oct 2019 04:04:13 -0400 Reply-To: tdevries@suse.de, simon.marchi@polymtl.ca, andrew.burgess@embecosm.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191015080413.3189129ECF@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00399.txt.bz2 Tom de Vries has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/30 ...................................................................... Patch Set 1: https://sourceware.org/ml/gdb-patches/2019-10/msg00343.html: ... On 14-10-2019 15:10, Alan Hayward wrote: >> This exposes 9 more FAILs of the PR tdep/25096 type, so mark all 12 of them as >> KFAIL. > When I run the test, I get three unexpected passes: > > > # of expected passes 9388 > # of unknown successes 3 > # of known failures 9 > > KPASS: gdb.base/infcall-nested-structs.exp: l=c++: types-tc-tf: p/d check_arg_struct_02_01 (ref_val_struct_02_01) (PRMS gdb/25096) > KPASS: gdb.base/infcall-nested-structs.exp: l=c++: types-ts-tf: p/d check_arg_struct_02_01 (ref_val_struct_02_01) (PRMS gdb/25096) > KPASS: gdb.base/infcall-nested-structs.exp: l=c++: types-ti-tf: p/d check_arg_struct_02_01 (ref_val_struct_02_01) (PRMS gdb/25096) That could be due to registers happening to have the correct value. Do these turn into KFAILs if you add: ... diff --git a/gdb/testsuite/gdb.base/infcall-nested-structs.exp b/gdb/testsuite/gdb.base/infcall-nested-structs. exp index 957eb31bdc2..f62f636aa11 100644 --- a/gdb/testsuite/gdb.base/infcall-nested-structs.exp +++ b/gdb/testsuite/gdb.base/infcall-nested-structs.exp @@ -134,6 +134,7 @@ proc run_tests { lang types } { if { $lang == "c++" && $name == "struct_02_01" && [regexp "^types-(tf-t(c|s|i)|t(c|s|i)-tf)" $types match] } { + gdb_test_no_output "set \$xmm0.v2_int64\[0\] = 0" setup_kfail gdb/25096 "x86_64-*-linux*" } gdb_test "p/d check_arg_${name} (ref_val_${name})" "= 1" ... ? ... -- To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/30 To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings