From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7857 invoked by alias); 15 Oct 2019 04:54:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7696 invoked by uid 89); 15 Oct 2019 04:54:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT autolearn=no version=3.3.1 spammy=HX-Languages-Length:828, visit, HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Oct 2019 04:54:02 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 557BB208FF; Tue, 15 Oct 2019 00:54:01 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 50E2B2061D; Tue, 15 Oct 2019 00:53:58 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 2E83A29ECF; Tue, 15 Oct 2019 00:53:58 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Tue, 15 Oct 2019 04:54:00 -0000 From: "Simon Marchi (Code Review)" To: Tom de Vries , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: Change in binutils-gdb[master]: [gdb/tdep] Fix inferior call arg passing for amd64 X-Gerrit-Change-Id: Id55c74755f0a431ce31223acc86865718ae0c123 X-Gerrit-Change-Number: 31 X-Gerrit-ChangeURL: X-Gerrit-Commit: e499f523ffa616f72d0ccb42849d55b3177d8d91 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 15 Oct 2019 00:53:58 -0400 Reply-To: simon.marchi@polymtl.ca, tdevries@suse.de, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191015045358.2E83A29ECF@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00397.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/31 ...................................................................... Patch Set 1: (1 comment) https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/31/1/gdb/amd64-tdep.c File gdb/amd64-tdep.c: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/31/1/gdb/amd64-tdep.c@645 PS1, Line 645: theclass[1] = amd64_merge_classes (theclass[1], subclass[1]); If we reach here, isn't subclass[1] always NO_CLASS? So this if would be unnecessary? -- To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/31 To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings