From: "Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Christian Biesinger <cbiesinger@google.com>, gdb-patches@sourceware.org
Subject: Change in binutils-gdb[master]: Make tui-winsource not use breakpoint_chain
Date: Tue, 15 Oct 2019 03:31:00 -0000 [thread overview]
Message-ID: <20191015033132.0CACD29ECF@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1570928756000.Ic259b2c3a4c1f5a47f34cfd7fccbdcf274417429@gnutoolchain-gerrit.osci.io>
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/22
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/22/2/gdb/tui/tui-winsource.c
File gdb/tui/tui-winsource.c:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/22/2/gdb/tui/tui-winsource.c@447
PS2, Line 447: return false;
Did you really want to introduce this `return false`?
--
To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/22
To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings
next parent reply other threads:[~2019-10-15 3:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gerrit.1570928756000.Ic259b2c3a4c1f5a47f34cfd7fccbdcf274417429@gnutoolchain-gerrit.osci.io>
2019-10-15 3:31 ` Simon Marchi (Code Review) [this message]
2019-10-15 8:43 ` Christian Biesinger (Code Review)
2019-10-15 8:43 ` Christian Biesinger (Code Review)
2019-10-15 12:26 ` Simon Marchi (Code Review)
2019-10-15 13:31 ` Sourceware to Gerrit sync (Code Review)
2019-10-15 13:31 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015033132.0CACD29ECF@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox