From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45307 invoked by alias); 14 Oct 2019 20:01:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45252 invoked by uid 89); 14 Oct 2019 20:01:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Oct 2019 20:01:29 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id A3E5620926; Mon, 14 Oct 2019 16:01:27 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 9780F20862; Mon, 14 Oct 2019 16:01:23 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 610D829ECF; Mon, 14 Oct 2019 16:01:23 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Mon, 14 Oct 2019 20:01:00 -0000 From: "Tom de Vries (Code Review)" To: Christian Biesinger , gdb-patches@sourceware.org Cc: Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: Change in binutils-gdb[master]: Load system gdbinit files from a directory X-Gerrit-Change-Id: If233859ecc21bc6421d589b37cd658a3c7d030f2 X-Gerrit-Change-Number: 26 X-Gerrit-ChangeURL: X-Gerrit-Commit: 248b0edb26c300233e6a2189d911c5c1f3687e47 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 14 Oct 2019 16:01:23 -0400 Reply-To: tdevries@suse.de, simon.marchi@polymtl.ca, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191014200123.610D829ECF@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00383.txt.bz2 Tom de Vries has posted comments on this change. ( https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26 ) Change subject: Load system gdbinit files from a directory ...................................................................... Patch Set 1: $ ../check_GNU_style.sh 0001-Load-system-gdbinit-files-from-a-directory.patch Lines should not exceed 80 characters. 414:+ /* We effectively don't support "set script-extension off/soft", 422:+ sysgdbinit.insert (sysgdbinit.end (), files.begin (), files.end ()); Dot, space, space, end of comment. 78:+ moved. */ Sentences should end with a dot. Dot, space, space, end of the comment. 74:+/* automatically load system-wide gdbinit files from this directory */ There should be exactly one space between function name and parenthesis. 410:+ if (stat(filename.c_str (), &s) != 0 || !S_ISREG (s.st_mode)) -- To view, visit https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/26 To unsubscribe, or for help writing mail filters, visit https://gnutoolchain-gerrit.osci.io/r/settings Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: If233859ecc21bc6421d589b37cd658a3c7d030f2 Gerrit-Change-Number: 26 Gerrit-PatchSet: 1 Gerrit-Owner: Christian Biesinger Gerrit-CC: Simon Marchi Gerrit-CC: Tom de Vries Gerrit-Comment-Date: Mon, 14 Oct 2019 20:01:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment