From: cbiesinger@chromium.org
To: gdb-patches@sourceware.org
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: [PATCH] Remote unnecessary declaration of trace_regblock_size
Date: Sat, 12 Oct 2019 05:06:00 -0000 [thread overview]
Message-ID: <20191012050554.51250-1-cbiesinger@chromium.org> (raw)
From: Christian Biesinger <cbiesinger@google.com>
This variable is declared in tracepoint.h, which is already included
by remote.c.
gdb/ChangeLog:
2019-10-10 Christian Biesinger <cbiesinger@google.com>
* remote.c (remote_target::get_trace_status): Remove declaration of
trace_regblock_size.
---
gdb/remote.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/gdb/remote.c b/gdb/remote.c
index 21160e13acc..73b510dd395 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -13102,14 +13102,13 @@ remote_target::get_trace_status (struct trace_status *ts)
{
/* Initialize it just to avoid a GCC false warning. */
char *p = NULL;
- /* FIXME we need to get register block size some other way. */
- extern int trace_regblock_size;
enum packet_result result;
struct remote_state *rs = get_remote_state ();
if (packet_support (PACKET_qTStatus) == PACKET_DISABLE)
return -1;
+ /* FIXME we need to get register block size some other way. */
trace_regblock_size
= rs->get_remote_arch_state (target_gdbarch ())->sizeof_g_packet;
--
2.23.0.700.g56cf767bdb-goog
next reply other threads:[~2019-10-12 5:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 5:06 cbiesinger [this message]
2019-10-12 23:31 ` Simon Marchi
2019-10-12 23:37 ` Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191012050554.51250-1-cbiesinger@chromium.org \
--to=cbiesinger@chromium.org \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox