Re: [PATCH 2/3] gdb: Split print_symbol_info into two parts

Simon Marchi
2019-10-04T01:50:14Z

> diff --git a/gdb/symtab.h b/gdb/symtab.h
> index 1f0fc62a657..f5da8229f2f 100644
> --- a/gdb/symtab.h
> +++ b/gdb/symtab.h
> @@ -2029,6 +2029,14 @@ extern std::vector<symbol_search> search_symbols (const char *,
> int,
> const char **,
> bool);
> +
> +/* Helper for print_symbol_info, return a string that describes SYM.
> + BLOCK is either GLOBAL_BLOCK or STATIC_BLOCK, and KIND is the type of
> + symbol that was searched for. */

Just a nit about this comment: I would not say that it's a helper for
print_symbol_info, which isn't an exported function. I think it's odd
to say that an exported function is a helper for an non-exported function
(where both are implemented in the same file).

Simon