From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [committed][gdb/testsuite] Make pass message unique in gdb-index.exp for cc-with-dwz-m
Date: Sun, 29 Sep 2019 21:52:00 -0000 [thread overview]
Message-ID: <20190929215246.GA23098@delia> (raw)
Hi,
With cc-with-dwz-m, we get:
...
PASS: gdb.dwarf2/gdb-index.exp: objcopy
PASS: gdb.dwarf2/gdb-index.exp: objcopy
...
Make the pass message unique by using with_test_prefix:
...
PASS: gdb.dwarf2/gdb-index.exp: objcopy
PASS: gdb.dwarf2/gdb-index.exp: modify dwz file: objcopy
...
Tested on x86_64-linux.
Committed to trunk.
Thanks,
- Tom
[gdb/testsuite] Make pass message unique in gdb-index.exp for cc-with-dwz-m
gdb/testsuite/ChangeLog:
2019-09-29 Tom de Vries <tdevries@suse.de>
* gdb.dwarf2/gdb-index.exp: Use with_test_prefix for second objcopy.
---
gdb/testsuite/gdb.dwarf2/gdb-index.exp | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/gdb/testsuite/gdb.dwarf2/gdb-index.exp b/gdb/testsuite/gdb.dwarf2/gdb-index.exp
index 6fca3c61299..b14e07fa55d 100644
--- a/gdb/testsuite/gdb.dwarf2/gdb-index.exp
+++ b/gdb/testsuite/gdb.dwarf2/gdb-index.exp
@@ -59,14 +59,16 @@ proc add_gdb_index { program } {
return ""
}
- if { [remote_file host exists ${dwz_index_file}] } {
- # We're modifying $dwz in place, otherwise we'd have to update
- # .gnu_debugaltlink in $program.
- set args [join [list "--remove-section .gdb_index" \
- " --add-section .gdb_index=$dwz_index_file" \
- " --set-section-flags .gdb_index=readonly $dwz"]]
- if {[run_on_host "objcopy" [gdb_find_objcopy] "$args"]} {
- return ""
+ with_test_prefix "modify dwz file" {
+ if { [remote_file host exists ${dwz_index_file}] } {
+ # We're modifying $dwz in place, otherwise we'd have to update
+ # .gnu_debugaltlink in $program.
+ set args [join [list "--remove-section .gdb_index" \
+ " --add-section .gdb_index=$dwz_index_file" \
+ " --set-section-flags .gdb_index=readonly $dwz"]]
+ if {[run_on_host "objcopy" [gdb_find_objcopy] "$args"]} {
+ return ""
+ }
}
}
reply other threads:[~2019-09-29 21:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190929215246.GA23098@delia \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox