From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26097 invoked by alias); 28 Sep 2019 20:09:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25313 invoked by uid 89); 28 Sep 2019 20:09:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Greylist:Sat, test-case X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 28 Sep 2019 20:09:44 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B3B2285536; Sat, 28 Sep 2019 20:09:42 +0000 (UTC) Received: from f29-4.lan (ovpn-117-13.phx2.redhat.com [10.3.117.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 84D8B102BD7C; Sat, 28 Sep 2019 20:09:42 +0000 (UTC) Date: Sat, 28 Sep 2019 20:09:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Tom de Vries Subject: Re: [PATCH][gdb/contrib] cc-with-tweaks.sh: Create .dwz file in .tmp subdir Message-ID: <20190928130942.1062250e@f29-4.lan> In-Reply-To: <20190822144220.GA6937@delia> References: <20190822144220.GA6937@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00575.txt.bz2 On Thu, 22 Aug 2019 16:42:22 +0200 Tom de Vries wrote: > When running a test-case gdb.base/foo.exp with cc-with-dwz-m, a file > build/gdb/testsuite/outputs/gdb.base/foo/foo.dwz will be created, alongside > executable build/gdb/testsuite/outputs/gdb.base/foo/foo. > > This can cause problems in f.i. test-cases that test file name completion. > > Make these problems less likely by moving foo.dwz to a .tmp subdir: > build/gdb/testsuite/outputs/gdb.base/foo/.tmp/foo.dwz. > > Tested on x86_64-linux. > > OK for trunk? > > Thanks, > - Tom > > [gdb/contrib] cc-with-tweaks.sh: Create .dwz file in .tmp subdir > > gdb/ChangeLog: > > 2019-08-22 Tom de Vries > > * contrib/cc-with-tweaks.sh (get_tmpdir): New function. > Use $tmpdir/$(basename "$output_file").dwz instead of > "${output_file}.dwz". LGTM. Kevin