From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: [PATCH] Move declaration of overload_resolution to value.h
Date: Thu, 19 Sep 2019 04:42:00 -0000 [thread overview]
Message-ID: <20190919044248.47444-1-cbiesinger@google.com> (raw)
The variable is defined in valops.c and has an extern decl in
eval.c; move it to the header file.
gdb/ChangeLog:
2019-09-19 Christian Biesinger <cbiesinger@google.com>
* eval.c: Move declaration of overload_resolution to...
* value.h: ...here.
---
gdb/eval.c | 3 ---
gdb/value.h | 2 ++
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/gdb/eval.c b/gdb/eval.c
index f8915b99578..70ba1f1e3fc 100644
--- a/gdb/eval.c
+++ b/gdb/eval.c
@@ -42,9 +42,6 @@
#include "typeprint.h"
#include <ctype.h>
-/* This is defined in valops.c */
-extern bool overload_resolution;
-
/* Prototypes for local functions. */
static struct value *evaluate_subexp_for_sizeof (struct expression *, int *,
diff --git a/gdb/value.h b/gdb/value.h
index 47bf672eb5d..0d75eaa5b21 100644
--- a/gdb/value.h
+++ b/gdb/value.h
@@ -81,6 +81,8 @@ struct value_print_options;
value_contents_eq for more info.
*/
+extern bool overload_resolution;
+
/* The structure which defines the type of a value. It should never
be possible for a program lval value to survive over a call to the
inferior (i.e. to be put into the history list or an internal
--
2.23.0.351.gc4317032e6-goog
next reply other threads:[~2019-09-19 4:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 4:42 Christian Biesinger via gdb-patches [this message]
2019-09-19 11:05 ` Simon Marchi
2019-09-20 0:20 ` Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919044248.47444-1-cbiesinger@google.com \
--to=gdb-patches@sourceware.org \
--cc=cbiesinger@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox