From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: [PATCH] Declare dwarf_always_disassemble in dwarf2read.h
Date: Thu, 19 Sep 2019 04:31:00 -0000 [thread overview]
Message-ID: <20190919043114.44137-1-cbiesinger@google.com> (raw)
In-Reply-To: <1b863842-8eef-42ad-8955-a0071752de2a@simark.ca>
[Simon, how's this? Compiles fine.]
And remove the declaration from dwarf2loc.c, for better typesafety.
gdb/ChangeLog:
2019-09-19 Christian Biesinger <cbiesinger@google.com>
* dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
* dwarf2read.h: Declare dwarf_always_disassemble.
---
gdb/dwarf2loc.c | 2 --
gdb/dwarf2read.h | 2 ++
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c
index 29fccae5944..c8ba0290a02 100644
--- a/gdb/dwarf2loc.c
+++ b/gdb/dwarf2loc.c
@@ -46,8 +46,6 @@
#include "gdbsupport/underlying.h"
#include "gdbsupport/byte-vector.h"
-extern bool dwarf_always_disassemble;
-
static struct value *dwarf2_evaluate_loc_desc_full (struct type *type,
struct frame_info *frame,
const gdb_byte *data,
diff --git a/gdb/dwarf2read.h b/gdb/dwarf2read.h
index 8939f97af53..e9b946247b0 100644
--- a/gdb/dwarf2read.h
+++ b/gdb/dwarf2read.h
@@ -33,6 +33,8 @@ extern struct cmd_list_element *show_dwarf_cmdlist;
typedef struct dwarf2_per_cu_data *dwarf2_per_cu_ptr;
DEF_VEC_P (dwarf2_per_cu_ptr);
+extern bool dwarf_always_disassemble;
+
/* A descriptor for dwarf sections.
S.ASECTION, SIZE are typically initialized when the objfile is first
--
2.23.0.351.gc4317032e6-goog
next prev parent reply other threads:[~2019-09-19 4:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 4:56 [PUSHED/OBVIOUS] Make extern declaration of dwarf_always_disassemble correct Christian Biesinger via gdb-patches
2019-09-18 11:17 ` Simon Marchi
2019-09-19 4:31 ` Christian Biesinger via gdb-patches [this message]
2019-09-19 11:01 ` [PATCH] Declare dwarf_always_disassemble in dwarf2read.h Simon Marchi
2019-09-20 0:15 ` Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919043114.44137-1-cbiesinger@google.com \
--to=gdb-patches@sourceware.org \
--cc=cbiesinger@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox