From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64111 invoked by alias); 15 Sep 2019 09:34:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64102 invoked by uid 89); 15 Sep 2019 09:34:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=flip, UD:gdb.exp, gdbexp, gdb.exp X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 15 Sep 2019 09:34:44 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id BFECAAE74 for ; Sun, 15 Sep 2019 09:34:42 +0000 (UTC) Date: Sun, 15 Sep 2019 09:34:00 -0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH][gdb/testsuite] Mark gdb.multi/multi-term-settings.exp FAIL as racy Message-ID: <20190915093435.GA27341@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00264.txt.bz2 Hi, This fail is racy: ... FAIL: gdb.multi/multi-term-settings.exp: inf1_how=attach: inf2_how=attach: \ stop with control-c (SIGINT) ... Mark it as such. OK for trunk? Thanks, - Tom [gdb/testsuite] Mark gdb.multi/multi-term-settings.exp FAIL as racy gdb/testsuite/ChangeLog: 2019-09-15 Tom de Vries PR testsuite/24929 * lib/gdb.exp (gdb_ignore_racy_test, setup_racy_fail): New proc. * gdb.multi/multi-term-settings.exp: Mark fail as racy. --- gdb/testsuite/gdb.multi/multi-term-settings.exp | 3 +++ gdb/testsuite/lib/gdb.exp | 20 ++++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/gdb/testsuite/gdb.multi/multi-term-settings.exp b/gdb/testsuite/gdb.multi/multi-term-settings.exp index 1c550aaa2e..7c29a65365 100644 --- a/gdb/testsuite/gdb.multi/multi-term-settings.exp +++ b/gdb/testsuite/gdb.multi/multi-term-settings.exp @@ -214,6 +214,9 @@ proc coretest {inf1_how inf2_how} { if {$expect_ttou} { gdb_test "" "Quit" "stop with control-c (Quit)" } else { + if { $inf1_how == "attach" && $inf2_how == "attach" } { + setup_racy_fail + } gdb_test "" "received signal SIGINT.*" "stop with control-c (SIGINT)" } diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index acbeb01376..2ca9a80870 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -5402,6 +5402,26 @@ proc gdb_skip_bogus_test { msg } { return 0 } +# Return 1 if we want to ignore FAILs that are known to be racy. + +proc gdb_ignore_racy_test { } { + # We want to have some means to enable this conditionally, but for now, + # hardcode this. + return 1 +} + +# Setup the next FAIL to be a racy FAIL. + +proc setup_racy_fail { } { + if { ! [gdb_ignore_racy_test] } { + return + } + + # Make the test flip between KPASS and KFAIL, instead of between PASS + # and FAIL. + setup_kfail gdb/racy *-*-* +} + # Return true if a test should be skipped due to lack of XML support # in the host GDB. # NOTE: This must be called while gdb is *not* running.