From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22545 invoked by alias); 13 Sep 2019 20:32:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22537 invoked by uid 89); 13 Sep 2019 20:32:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-qt1-f172.google.com Received: from mail-qt1-f172.google.com (HELO mail-qt1-f172.google.com) (209.85.160.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Sep 2019 20:32:27 +0000 Received: by mail-qt1-f172.google.com with SMTP id x5so3742104qtr.7 for ; Fri, 13 Sep 2019 13:32:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=S/I0ZNMYwtZGjx8CD9Xf8Fg0rpmPcV4C32Bux4lwnl0=; b=dMAoSymVcJsBrXKEgS8T0DciCLDMP6IhX6LkQxW43DxPtmdV0Rl3KHCsQt0s7sD3rR Unna94sX/wWLu2ACKq4YRVjIbWaVXKEODv4+mVXFB2ixP7nhIVtac230qV9obUitG3c1 pU8um/BhrJW4Jay6iHG0lbiVqeB5skyFo7r8lIcWIKCw0vjxqiHmfewBEepUeMPHFJBc pgtK8zj4zGIEhwrjp4Vxj4wca9HeeRq1Q9aD7+dIQCuTx77G5P54GOn4updJk7Fq5wnv IfNuK4mCmzMTtO1e7Xaz1Lgq5+U68c4W3cPQfWfeTcBgVovaT5eG6DWyScl+DIma9A04 L/KA== Return-Path: Received: from localhost ([198.168.27.218]) by smtp.gmail.com with ESMTPSA id n65sm13224517qkb.19.2019.09.13.13.32.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Sep 2019 13:32:23 -0700 (PDT) Date: Fri, 13 Sep 2019 20:32:00 -0000 From: Andrew Burgess To: Tom de Vries Cc: gdb-patches@sourceware.org, Tom Tromey , Philippe Waroquiers Subject: Re: [PING][PATCH][gdb/testsuite] Require gnatmake 8 for gdb.ada/rename_subscript_param.exp Message-ID: <20190913203222.GU6076@embecosm.com> References: <20190829143754.GA18195@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Fortune: Fat people of the world unite, we've got nothing to lose! X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00242.txt.bz2 * Tom de Vries [2019-09-13 20:08:52 +0200]: > On 29-08-19 16:37, Tom de Vries wrote: > > Hi, > > > > When running gdb.ada/rename_subscript_param.exp with gnatmake 7.4.1, we get: > > ... > > FAIL: gdb.ada/rename_subscript_param.exp: print rename_subscript_param_b \ > > before changing its value > > FAIL: gdb.ada/rename_subscript_param.exp: print rename_subscript_param_b \ > > after changing its value > > ... > > > > The commit last touching the test-case (afcfda091e) states: > > ... > > The test still fails with old compilers that do not properly > > generate debug info for this renaming: > > ... > > > > Fix this by requiring at least gnatmake 8 for the test-case. > > > > Tested on x86_64-linux. > > > > OK for trunk? > > > > Ping. Looks good to me. Thanks, Andrew > > Thanks, > - Tom > > > [gdb/testsuite] Require gnatmake 8 for gdb.ada/rename_subscript_param.exp > > > > gdb/testsuite/ChangeLog: > > > > 2019-08-29 Tom de Vries > > > > PR teststuite/24599 > > * gdb.ada/rename_subscript_param.exp: Require gnatmake 8. > > * lib/ada.exp (gnatmake_version_at_least): New proc. > > > > --- > > gdb/testsuite/gdb.ada/rename_subscript_param.exp | 4 ++++ > > gdb/testsuite/lib/ada.exp | 19 +++++++++++++++++++ > > 2 files changed, 23 insertions(+) > > > > diff --git a/gdb/testsuite/gdb.ada/rename_subscript_param.exp b/gdb/testsuite/gdb.ada/rename_subscript_param.exp > > index ffcfa50df3..fd8208825a 100644 > > --- a/gdb/testsuite/gdb.ada/rename_subscript_param.exp > > +++ b/gdb/testsuite/gdb.ada/rename_subscript_param.exp > > @@ -15,6 +15,10 @@ > > > > load_lib "ada.exp" > > > > +if { ![gnatmake_version_at_least 8] } { > > + return -1 > > +} > > + > > standard_ada_testfile pb30_012 > > > > if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug]] != "" } { > > diff --git a/gdb/testsuite/lib/ada.exp b/gdb/testsuite/lib/ada.exp > > index 1345c747c5..95f0f525b1 100644 > > --- a/gdb/testsuite/lib/ada.exp > > +++ b/gdb/testsuite/lib/ada.exp > > @@ -105,3 +105,22 @@ proc find_ada_tool {tool} { > > > > return $result > > } > > + > > +# Return 1 if gnatmake is at least version $MAJOR.x.x > > + > > +proc gnatmake_version_at_least { major } { > > + set gnatmake [gdb_find_gnatmake] > > + set gnatmake [lindex [split $gnatmake] 0] > > + set output [exec $gnatmake --version] > > + if { [regexp {GNATMAKE ([^ .]+).([^ .]+).([^ .]+)} $output \ > > + match gnatmake_major gnatmake_minor gnatmake_micro] } { > > + if { $gnatmake_major >= $major } { > > + return 1 > > + } else { > > + return 0 > > + } > > + } > > + > > + # Unknown, return 1 > > + return 1 > > +} > >