From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89714 invoked by alias); 9 Sep 2019 20:53:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89696 invoked by uid 89); 9 Sep 2019 20:53:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=nod, probes X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Sep 2019 20:53:20 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D5FD6117638; Mon, 9 Sep 2019 16:53:18 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id bcUbt9nyFVim; Mon, 9 Sep 2019 16:53:18 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 8948411739B; Mon, 9 Sep 2019 16:53:18 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id A7F8D82B6C; Mon, 9 Sep 2019 13:53:16 -0700 (PDT) Date: Mon, 09 Sep 2019 20:53:00 -0000 From: Joel Brobecker To: Sergio Durigan Junior Cc: Tom de Vries , gdb-patches@sourceware.org Subject: Re: [PING][8.3 backport] Adjust i386 registers on SystemTap probes' arguments (PR breakpoints/24541) Message-ID: <20190909205316.GA530@adacore.com> References: <20190714175240.GA23822@adacore.com> <877e7i3vpr.fsf@redhat.com> <2b220c6a-e212-65b0-e6e6-f668602179c6@suse.de> <31f1ccbe-535f-1f69-9ba8-e51a9a8e8a12@suse.de> <87r24wt3ki.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87r24wt3ki.fsf@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2019-09/txt/msg00148.txt.bz2 > >> OK to backport both commits to gdb-8.3-branch? > > > > Ping. > > I'm the maintainer of the SystemTap/generic probe interfaces, but I'm > not sure I can give you the green light for you in this case, because > it's about backporting to a branch. In any case, just to make sure I'm > clear: this one LGTM. Generally speaking, the rule is that a GM needs to approve the backport. But the nod from the associated maintainer is always a great help. So thanks a lot, Sergio! I looked it over, and this seems safe to have. So the backport is approved. One thing that would have helped a bit is if the commits were attached to the request. It's clearly not a big issue at all, but if they had been attached, there would have been no mistake possible fo which commits we are talking about, and looking through them would have been faster. For the record, I looked at: 677052f2a5 Make stap-probe.c:stap_parse_register_operand's "regname" an std::string 7d7571f0c1 Adjust i386 registers on SystemTap probes' arguments (PR breakpoints/24541) -- Joel