From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29521 invoked by alias); 4 Sep 2019 11:49:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29471 invoked by uid 89); 4 Sep 2019 11:49:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Sep 2019 11:49:00 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 054203082145; Wed, 4 Sep 2019 11:48:59 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-117-1.ams2.redhat.com [10.36.117.1]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1B0CA60BFB; Wed, 4 Sep 2019 11:48:57 +0000 (UTC) Date: Wed, 04 Sep 2019 11:49:00 -0000 From: Jan Kratochvil To: Tom de Vries Cc: "gdb-patches@sourceware.org" , Alan Hayward Subject: Re: [RFC][gdb/testsuite] Remove breakpoint command in gdb.base/ui-redirect.exp Message-ID: <20190904114855.GA13625@host1.jankratochvil.net> References: <3150ecd9-9221-4360-6a16-563b3c5ef1ab@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3150ecd9-9221-4360-6a16-563b3c5ef1ab@suse.de> User-Agent: Mutt/1.12.1 (2019-06-15) X-SW-Source: 2019-09/txt/msg00027.txt.bz2 On Tue, 03 Sep 2019 19:43:44 +0200, Tom de Vries wrote: > I noticed a bit in gdb.base/ui-redirect.exp that sets a breakpoint > command on main, but then due to runto_main, the break point is deleted: ... > In the original commit ( submission here > https://sourceware.org/ml/gdb-patches/2010-09/msg00120.html ) there was > no runto_main, and the breakpoint command was not triggered either. > > Is this some artefact, and can it be removed, or is it actually testing > something related to redirection? It looks to me the patch which added the "runto_main" part: commit ca1285d17534cff3041c07ac7841288e1b3ba19c Author: Alan Hayward Date: Fri May 17 14:15:01 2019 +0100 Add debug redirect option disabled the regression testing. "runto_main" should be removed otherwise the testcase does not test anything (or it just tests less). Jan