From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57150 invoked by alias); 30 Aug 2019 15:51:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57137 invoked by uid 89); 30 Aug 2019 15:51:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Aug 2019 15:51:55 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7BBF530024DA; Fri, 30 Aug 2019 15:51:54 +0000 (UTC) Received: from blade.nx (unknown [10.36.118.106]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4027410001BC; Fri, 30 Aug 2019 15:51:54 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id 3BAA2816CC28; Fri, 30 Aug 2019 16:51:53 +0100 (BST) Date: Fri, 30 Aug 2019 15:51:00 -0000 From: Gary Benson To: Alan Hayward Cc: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH v2 0/3] Fix stop-on-solib event failures Message-ID: <20190830155151.GA11044@blade.nx> References: <20190821155816.45504-1-alan.hayward@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190821155816.45504-1-alan.hayward@arm.com> X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00657.txt.bz2 Hi Alan, Alan Hayward wrote: > On some Arm targets (namely the buildbot Arm Docker setup) placing > breakpoints on just the solib dynamic probes will cause the target > process to not stop. This is due to the probes being invalid - see > link in 3/3 for more details. > > Fix is to fully validate the probes before using the,. > > Patches 1 and 2 are code refactors. The actual fix is in patch 3. The code looks good to me, my only caveat being that I think we're supposed to wrap lines at 72 columns (unless that changed) and some lines in your patches seem too long. I noticed it in comments, but possibly it's in code too. With that fixed (or, not fixed if we don't wrap at 72 columns any more) I'd say this is good to commit. Thank you for doing the work! Cheers, Gary