Re: [PUSHED/OBVIOUS] Don't duplicate comment in symfile.c and .h

Christian Biesinger via gdb-patches
2019-09-20T02:59:12Z

argh, accidentally sent the wrong file. please disregard (this is a duplicate)

On Fri, Sep 20, 2019 at 11:57 AM Christian Biesinger
<cbiesinger@google.com> wrote:
>
> This just replaces the comment in the .c file with
> "See symfile.h.".
>
> gdb/ChangeLog:
>
> 2019-09-16 Christian Biesinger <cbiesinger@google.com>
>
> * symfile.c (auto_solib_add): Replace comment with a reference
> to the header file.
> ---
> gdb/symfile.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/gdb/symfile.c b/gdb/symfile.c
> index 3cd514409b..259a30aa04 100644
> --- a/gdb/symfile.c
> +++ b/gdb/symfile.c
> @@ -141,15 +141,7 @@ static const char *print_symbol_loading_enums[] =
> };
> static const char *print_symbol_loading = print_symbol_loading_full;
>
> -/* If non-zero, shared library symbols will be added automatically
> - when the inferior is created, new libraries are loaded, or when
> - attaching to the inferior. This is almost always what users will
> - want to have happen; but for very large programs, the startup time
> - will be excessive, and so if this is a problem, the user can clear
> - this flag and then add the shared library symbols as needed. Note
> - that there is a potential for confusion, since if the shared
> - library symbols are not loaded, commands like "info fun" will *not*
> - report all the functions that are actually present. */
> +/* See symfile.h. */
>
> int auto_solib_add = 1;
>
> --
> 2.23.0.237.gc6a4ce50a0-goog
>