From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89174 invoked by alias); 22 Aug 2019 16:56:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89163 invoked by uid 89); 22 Aug 2019 16:56:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=kevin X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Aug 2019 16:56:54 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DCF8330832DA; Thu, 22 Aug 2019 16:56:52 +0000 (UTC) Received: from f29-4.lan (ovpn-117-6.phx2.redhat.com [10.3.117.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B2AA75D6A7; Thu, 22 Aug 2019 16:56:52 +0000 (UTC) Date: Thu, 22 Aug 2019 16:56:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Yoshinori Sato Subject: Re: [PATCH v3] Convert the RX target to make use of target descriptions. Message-ID: <20190822095652.340db6e6@f29-4.lan> In-Reply-To: <20190822143026.82014-1-ysato@users.sourceforge.jp> References: <20190822143026.82014-1-ysato@users.sourceforge.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00531.txt.bz2 On Thu, 22 Aug 2019 23:30:26 +0900 Yoshinori Sato wrote: > gdb/ChangeLog > > 2019-08-22 Yoshinori Sato > > * gdb/rx-tdep.c (rx_register_names): New. > (rx_register_name): delete. > (rx_psw_type): delete. > (rx_fpsw_type): delete. > (rx_register_type): delete. > (rx_gdbarch_init): Convert target-descriptions. > (_initialize_rx_tdep): Add initialize_tdesc_rx. > * gdb/features/Makefile: Add rx.xml. > * gdb/features/rx.xml: New. > * gdb/features/rx.c: Likewise. > * gdb/NEWS: Mention target description support. One small nit - for gdb/features/rx.c, I'd prefer to see a ChangeLog comment saying that it's been generated. I.e. * gdb/features/rx.c: Generate. The rest looks good to me. If there are no other suggestions from someone else, go ahead and commit it with that small tweak. Kevin