From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114912 invoked by alias); 9 Aug 2019 19:17:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114903 invoked by uid 89); 9 Aug 2019 19:17:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Aug 2019 19:17:41 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 14C8E69094; Fri, 9 Aug 2019 19:17:40 +0000 (UTC) Received: from f29-4.lan (ovpn-117-6.phx2.redhat.com [10.3.117.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DF8F760872; Fri, 9 Aug 2019 19:17:39 +0000 (UTC) Date: Fri, 09 Aug 2019 19:17:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Pedro Franco de Carvalho Subject: Re: [PATCH] Fix access to uninitialized variable in fill_in_stop_func Message-ID: <20190809121739.29f6e33e@f29-4.lan> In-Reply-To: <20190809191313.25200-1-pedromfc@linux.ibm.com> References: <20190808104200.6a387ac8@f29-4.lan> <20190809191313.25200-1-pedromfc@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00237.txt.bz2 On Fri, 9 Aug 2019 16:13:13 -0300 Pedro Franco de Carvalho wrote: > This patch changes find_pc_partial_function so that *block is set to > nullptr when it fails, so that fill_in_stop_func won't access an > uninitialized variable. > > gdb/ChangeLog: > YYYY-MM-DD Pedro Franco de Carvalho > > * blockframe.c (find_pc_partial_function): Set *block to nullptr > when the function fails. Okay. Kevin