From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77078 invoked by alias); 9 Aug 2019 08:33:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77069 invoked by uid 89); 9 Aug 2019 08:33:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=sites X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Aug 2019 08:33:36 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BDA0165F66; Fri, 9 Aug 2019 08:33:34 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-117-1.ams2.redhat.com [10.36.117.1]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0A2D010013A1; Fri, 9 Aug 2019 08:33:33 +0000 (UTC) Date: Fri, 09 Aug 2019 08:33:00 -0000 From: Jan Kratochvil To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb] Fix gdb.dwarf2/amd64-entry-value-param.exp with -fPIE/-pie Message-ID: <20190809083331.GA14408@host1.jankratochvil.net> References: <20190809075424.GA15972@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190809075424.GA15972@delia> User-Agent: Mutt/1.12.1 (2019-06-15) X-SW-Source: 2019-08/txt/msg00216.txt.bz2 On Fri, 09 Aug 2019 09:54:26 +0200, Tom de Vries wrote: > Fix this by eliminating baseaddr from read_call_site_scope, and handling the > relocation offset at the use sites in call_site_for_pc and > call_site_to_target_addr. It sure looks correct to me that way, thanks. This is not a commit approval. Thanks, Jan Kratochvil