From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-157547-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 86032 invoked by alias); 16 Jul 2019 17:25:24 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 86023 invoked by uid 89); 16 Jul 2019 17:25:24 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 Jul 2019 17:25:23 +0000
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 655912BE94;	Tue, 16 Jul 2019 17:25:22 +0000 (UTC)
Received: from f29-4.lan (ovpn-117-224.phx2.redhat.com [10.3.117.224])	by smtp.corp.redhat.com (Postfix) with ESMTPS id 3BB4260C6D;	Tue, 16 Jul 2019 17:25:22 +0000 (UTC)
Date: Tue, 16 Jul 2019 17:25:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Remove a VEC from s390-linux-nat.c
Message-ID: <20190716102521.14294b41@f29-4.lan>
In-Reply-To: <20190715202758.23743-1-tromey@adacore.com>
References: <20190715202758.23743-1-tromey@adacore.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2019-07/txt/msg00375.txt.bz2

On Mon, 15 Jul 2019 14:27:58 -0600
Tom Tromey <tromey@adacore.com> wrote:

> This removes a use of VEC fro s390-linux-nat.c, replacing it with
> std::vector.
> 
> Tested using the Fedora-s390x-m64 buildbot builder.
> 
> gdb/ChangeLog
> 2019-07-15  Tom Tromey  <tromey@adacore.com>
> 
> 	* s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
> 	declare VEC.
> 	(struct s390_debug_reg_state) <watch_areas, break_areas>: Now
> 	std::vector.
> 	(struct s390_process_info): Add initializers.
> 	(s390_add_process): Use new.
> 	(s390_linux_nat_target::low_forget_process): Use delete.
> 	(s390_linux_nat_target::low_new_fork)
> 	(s390_linux_nat_target::stopped_by_watchpoint)
> 	(s390_linux_nat_target::low_prepare_to_resume)
> 	(s390_linux_nat_target::insert_watchpoint)
> 	(s390_linux_nat_target::insert_hw_breakpoint)
> 	(s390_linux_nat_target::remove_watchpoint)
> 	(s390_linux_nat_target::remove_hw_breakpoint): Update.

LGTM.

Kevin