From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28568 invoked by alias); 11 Jul 2019 19:21:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28560 invoked by uid 89); 11 Jul 2019 19:21:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-wr1-f66.google.com Received: from mail-wr1-f66.google.com (HELO mail-wr1-f66.google.com) (209.85.221.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Jul 2019 19:21:28 +0000 Received: by mail-wr1-f66.google.com with SMTP id n9so7492874wrr.4 for ; Thu, 11 Jul 2019 12:21:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9Fw45m9l0Ixhk6T/7TMTfl7AU1RpIBG/gSZ8f7eow0M=; b=EuOgILjaD4bgD6Nq6iBP/SWIN8blw1apcmjOAPsP4k4d8XgJrbLdBjy5eSdFobFABh N1aUazEXX5d2a8DrTRLWbRSoEUo5+WEeCJFQZS5nGBJqmnV9Md6hAgMl2txyhiyKnf6Z 9NOAQOIm2SZmrTxIz3lAsrVgR/dfvuXduyamvAl1w9ZJJjEauN1J71JTQA/nUIQa7Co+ zjccO6R/p/DyO7peIgAd/lDz+DUVhjia9un5mAECYkSUbgVfJDzbHfg+uVlTpQVe5W18 Qml5d6iffLPc28NSIiq0pmEU1f+bjnOBrym4/BYundWo6M535QNCCrSndx6ZCUXonKgM 4Yew== Return-Path: Received: from localhost (host86-128-12-99.range86-128.btcentralplus.com. [86.128.12.99]) by smtp.gmail.com with ESMTPSA id b8sm7385363wmh.46.2019.07.11.12.21.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Jul 2019 12:21:25 -0700 (PDT) Date: Thu, 11 Jul 2019 19:21:00 -0000 From: Andrew Burgess To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/2] Make use of gdb::options for info variabels|functions|args|locals Message-ID: <20190711192124.GQ23204@embecosm.com> References: <306a840c-719a-0398-26cd-34142ba05167@redhat.com> <20190711155305.GO23204@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Fortune: If you are too busy to read, then you are too busy. X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg00335.txt.bz2 * Pedro Alves [2019-07-11 17:05:18 +0100]: > On 7/11/19 4:53 PM, Andrew Burgess wrote: > > * Pedro Alves [2019-07-11 14:36:23 +0100]: > > > >> On 7/11/19 2:20 PM, Andrew Burgess wrote: > >>> Additional use of the gdb::options framework. > >>> > >>> -- > >>> > >>> Andrew Burgess (2): > >>> gdb: Allow quoting around string options in the gdb::option framework > >> > >> Ahaha, that didn't take long. Thanks for doing this. LGTM. > >> > >>> gdb: Make use of gdb::option framework for some info commands > >> > >> This LGTM to me too, but, I was surprised to find this doesn't add > >> completers at the same time? > > > > Something like this, maybe? > > _Exactly_ like that. Perfect. > > So far, I've listed this sort of improvement under > "Completion improvements" in NEWS. I think you lists these commands > there too, and it'd be an obvious change. > > > + > > + const char *word = advance_to_expression_complete_word_point (tracker, text); > > + symbol_completer (ignore, tracker, text, word); > > + return; > > Redundant "return". Pushed with "return" fixed, and a NEWS entry. Thanks, Andrew > > Thanks, > Pedro Alves