Re: [PATCH v2 1/5] Arm: Add read_description read funcs and use in GDB

Simon Marchi
2019-07-11T14:19:39Z

On 2019-07-11 9:46 a.m., Alan Hayward wrote:
> Switch the Arm target to get target descriptions via arm_read_description
> and aarch32_read_description, in the same style as other feature targets.
> Add an enum to specify the different types - this will also be of use to
> gdbserver in a later patch.
>
> Under the hood return the same existing pre-feature target descriptions.
>
> Note: This commit will break the AArch64 gdbserver build.

Sorry for spamming you, one last thing :)

I forgot to ask you, what is it in this patch that is breaking the AArch64
gdbserver build in this? And what would it take for you not to break it?

We generally try to keep things building at each commit, so I'd just like
a bit more justifications about why it's worth breaking it here, rather than
doing the necessary work to keep it building.

Simon