Re: [PATCH v2 1/5] Arm: Add read_description read funcs and use in GDB

Simon Marchi
2019-07-11T13:56:00Z

Hi Alan,

Just this nit:

> diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
> index 7b60a9a0c3..4db0288e68 100644
> --- a/gdb/aarch64-linux-nat.c
> +++ b/gdb/aarch64-linux-nat.c
> @@ -27,9 +27,11 @@
> #include "target-descriptions.h"
> #include "auxv.h"
> #include "gdbcmd.h"
> +#include "arch/arm.h"
> #include "aarch64-tdep.h"
> #include "aarch64-linux-tdep.h"
> #include "aarch32-linux-nat.h"
> +#include "aarch32-tdep.h"
> #include "arch/arm.h"
> #include "nat/aarch64-linux.h"
> #include "nat/aarch64-linux-hw-point.h"

The "arch/arm.h" include is duplicated here.

Simon